Fix potential panics from date string slicing#5
Open
JonBasse wants to merge 2 commits intobuddyh:mainfrom
Open
Fix potential panics from date string slicing#5JonBasse wants to merge 2 commits intobuddyh:mainfrom
JonBasse wants to merge 2 commits intobuddyh:mainfrom
Conversation
Add bounds checks before slicing date strings to prevent panics when CompletedAt or PostedAt fields are shorter than 10 characters. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- ConfigDir() and ConfigPath() now return errors instead of silently ignoring os.UserHomeDir() failures - Update all call sites to handle the new error returns - Remove unused splitLabels() function from update.go Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
JonBasse
force-pushed
the
fix/prevent-substring-panics
branch
from
5efd264 to
25b70cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.UserHomeDir()errors instead of silently ignoring themsplitLabels()functionChanges
Panic prevention (commit 1)
internal/output/format.go: Add bounds check inWriteCompletedTasks()before slicingCompletedAtcmd/todoist/view.go: Add bounds check before slicingPostedAtin comment displayError handling improvement (commit 2)
internal/config/config.go:ConfigDir()andConfigPath()now return(string, error)instead of juststringcmd/todoist/auth.go: Updated to handle new error returns from config functionsDead code removal (commit 2)
cmd/todoist/update.go: Removed unusedsplitLabels()function andstringsimportTest plan
go build ./...)go test ./...)🤖 Generated with Claude Code